Feat/#123 market api #132
Merged
Feat/#123 market api #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
โฆt/#123_marketAPI
โฆt/#123_marketAPI
urlotus
reviewed
Sep 5, 2023
| _fetchMarketArticles(); | ||
| } | ||
|
|
||
| Future<void> _fetchMarketArticles() async { |
There was a problem hiding this comment.
์ค ๋น ๋ฆฌ์คํธ ๋ง๋ค์ด์ ๋ฐ์ดํฐ ๋ฐ์์ค๋๋ก ๊ตฌ์ฑํ์
จ๊ตฐ์
๊ทธ๋ผ ๋ฐ์์ค๋ ๋์ ์๋ฌด ๊ฐ๋ ์๋ ์ํ์์๋ null ์ค๋ฅ๊ฐ ์์ผ์ด๋๋์??
There was a problem hiding this comment.
null ์ค๋ฅ๋ ์์ผ์ด๋๋๋ฐ ์ข๋ ui ์ ์ผ๋ก ๋ก๋ฉ์ ์ถ๊ฐ์ฒ๋ฆฌํด์ผํ ํ์๋ ์์ด๋ณด์ ๋๋ค
urlotus
reviewed
Sep 5, 2023
| marketcommentProvider.getMarketComments(widget.marketBoard.articleId!); | ||
|
|
||
| bool showLoading = marketcommentProvider.loading; | ||
| if (showLoading) { |
There was a problem hiding this comment.
์ด if ๋ฌธ์ด build ์์ ์์ด๋ ๊ด์ฐฎ์๊ฐ์??
์์ ฏ ๊ทธ๋ ค์ง ๋๋ง๋ค ์ํ๋ ๊ฒ ๊ฐ์๋ฐ ๊ณ์ showLoading์ด false๊ฐ ๋์ด๋ ๊ด์ฐฎ์์ง ๊ถ๊ธํฉ๋๋ค
There was a problem hiding this comment.
ํ ๊ทธ๋์ pr์ ์ ์ด๋จ๋ ๊ฑฐ ์ฒ๋ผ ๊ณ์ ํด์ ๋ก๋ฉ์ด ์งํ๋๊ฑธ๊น์.. ํ๋ฒ ์์ ํด๋ณด๊ฒ ์ต๋๋ค
urlotus
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐คจ Motivation
๐ Key Changes
๐ To Reviewers