Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/dialog box #106

Merged
merged 3 commits into from
Jul 6, 2024
Merged

Test/dialog box #106

merged 3 commits into from
Jul 6, 2024

Conversation

444B
Copy link
Owner

@444B 444B commented Jul 6, 2024

Pull Request Template

TL;DR

Provide a brief summary of the changes made.

  • shows the display results inside a dialogbox

Problem Solved

  1. Describe the problem your changes address.
  2. Please mention the issue number if relevant
  • ease of use and reduced having to scroll down to bottom of the page to see results

Screenshots

If applicable, add screenshots to help explain your solution. For adding images, use:

Changes Made(Optional)

List the main changes in bullet points.

  • results now show in a dialogbox

Manual Testing

  • You have manually tested all changes to ensure they work as intended. Replace the [ ] with a [X] if True.

How was this tested?
Describe the tests that you ran to verify your changes.

  • uploaded to testpypi and run locally. Can ignore failed test package since I have to push a new version with a typo fix

Additional Notes

Include any additional information that might be relevant for reviewers.

@444B 444B self-assigned this Jul 6, 2024
@444B
Copy link
Owner Author

444B commented Jul 6, 2024

Failed GH action WF can be ignored since I had to push a new commit with an existing 8.0.0 version and testpypi wont accept duplicate numbers. This will be accepted in main branch

@444B 444B merged commit 5915f53 into main Jul 6, 2024
3 of 4 checks passed
@444B 444B deleted the test/dialog_box branch July 6, 2024 14:49
@444B 444B restored the test/dialog_box branch July 6, 2024 14:58
444B added a commit that referenced this pull request Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant