Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new options about safeguards #521

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Add new options about safeguards #521

merged 2 commits into from
Nov 17, 2023

Conversation

Gustry
Copy link
Member

@Gustry Gustry commented Oct 26, 2023

@Gustry Gustry force-pushed the safeguards branch 7 times, most recently from caedc77 to b61d841 Compare October 31, 2023 12:03
@Gustry
Copy link
Member Author

Gustry commented Oct 31, 2023

Ok, finally the technical part is ready @nboisteault @nworr and @mdouchin

It needs some polishing, but the PR is ready for testing :

  • UI/UX
  • Do we want the JSON output of the table in the CFG, the checkbox which is now visible (but designed to be later)
  • Review rules and severities
  • Is blocking the CFG file is a good UX, if someone did a lot of change in the plugin ? (I don't think it's a blocker)
  • General table

The severity/rules is a mix of :

  • version of target LWC
  • version of QGIS used
  • Lizmap Cloud yes/no
  • Beginner/Normal

which is defined on checktime only

  • Rename panel

Copy link
Contributor

@mdouchin mdouchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will get the branch locally and test it, this first review is to prevent from not using from +ing with the verb prevent 🤪

lizmap/project_checker_tools.py Outdated Show resolved Hide resolved
@nboisteault
Copy link
Member

@Gustry I have tested and I love it!

@mdouchin
Copy link
Contributor

mdouchin commented Nov 2, 2023

Tested with a project having lots of blocking and non-blocking issues, and loved it too !

@mdouchin
Copy link
Contributor

mdouchin commented Nov 2, 2023

I loooove the Help tab too !

Copy link
Contributor

@mdouchin mdouchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the help pane, the How-to fix should show the simplest method for QGIS>=3.22 at the top, instead of letting the user read a more complex solution.

* With QGIS ≥ 3.22, you can use the auto-fix button in the "Settings" panel of the plugin
* Or edit your global PostgreSQL connection to enable this option, then change the datasource by right clicking on each layer above, then click "Change datasource" in the menu. Finally reselect your layer in the new dialog with the updated connection. When opening a QGIS project in your desktop, you mustn't have any prompt for a user or password. The edited connection will take effect only on newly added layer into a project that's why the right-click step is required.

instead of

* Edit your global PostgreSQL connection to enable this option, then change the datasource by right clicking on each layer above, then click "Change datasource" in the menu. Finally reselect your layer in the new dialog with the updated connection. When opening a QGIS project in your desktop, you mustn't have any prompt for a user or password. The edited connection will take effect only on newly added layer into a project that's why the right-click step is required.
* Or with QGIS ≥ 3.22, you can use the auto-fix button in the "Settings" panel of the plugin

@nboisteault
Copy link
Member

@Gustry does "Edit your global PostgreSQL connection to enable this option" action is done when using the auto-fix button? If we don't want to do that instead of the user (maybe he does not want this option activated on the datasource), maybe we could add a button to do that.

@Gustry
Copy link
Member Author

Gustry commented Nov 6, 2023

the How-to fix should show the simplest method for QGIS>=3.22 at the to

Actually, for now, both are needed, it's not a "OR", but a "AND". One is to edit global connection, the other for current loaded layers

does "Edit your global PostgreSQL connection to enable this option" action is done when using the auto-fix button?

Everything is written, with bold : no :)

image

maybe we could add a button to do that

Yes, this is the idea, that's why the current group box title is Auto repair tools on the project, to have later Auto repair tools on global configurations ;-)

@Gustry Gustry force-pushed the safeguards branch 2 times, most recently from 39c4ac4 to 1e7ae19 Compare November 10, 2023 16:37
@Gustry Gustry marked this pull request as ready for review November 17, 2023 14:40
@Gustry
Copy link
Member Author

Gustry commented Nov 17, 2023

Let's merge and let's give it a try ...

@Gustry Gustry merged commit a552cad into 3liz:master Nov 17, 2023
6 checks passed
@Gustry Gustry deleted the safeguards branch November 17, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a new panel for some "settings" Check postgresql layers for credentials
3 participants