-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new options about safeguards #521
Conversation
Gustry
commented
Oct 26, 2023
•
edited
Loading
edited
- Funded by: 3Liz
- Description:
- Fix Add a new panel for some "settings" #520
- Fix Check postgresql layers for credentials #388
- Realated to QGIS project with a PostgreSQL layer lizmap-web-client#1638
caedc77
to
b61d841
Compare
Ok, finally the technical part is ready @nboisteault @nworr and @mdouchin It needs some polishing, but the PR is ready for testing :
The severity/rules is a mix of :
which is defined on checktime only
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will get the branch locally and test it, this first review is to prevent from not using from +ing with the verb prevent 🤪
@Gustry I have tested and I love it! |
Tested with a project having lots of blocking and non-blocking issues, and loved it too ! |
I loooove the Help tab too ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the help pane, the How-to fix
should show the simplest method for QGIS>=3.22 at the top, instead of letting the user read a more complex solution.
* With QGIS ≥ 3.22, you can use the auto-fix button in the "Settings" panel of the plugin
* Or edit your global PostgreSQL connection to enable this option, then change the datasource by right clicking on each layer above, then click "Change datasource" in the menu. Finally reselect your layer in the new dialog with the updated connection. When opening a QGIS project in your desktop, you mustn't have any prompt for a user or password. The edited connection will take effect only on newly added layer into a project that's why the right-click step is required.
instead of
* Edit your global PostgreSQL connection to enable this option, then change the datasource by right clicking on each layer above, then click "Change datasource" in the menu. Finally reselect your layer in the new dialog with the updated connection. When opening a QGIS project in your desktop, you mustn't have any prompt for a user or password. The edited connection will take effect only on newly added layer into a project that's why the right-click step is required.
* Or with QGIS ≥ 3.22, you can use the auto-fix button in the "Settings" panel of the plugin
@Gustry does "Edit your global PostgreSQL connection to enable this option" action is done when using the auto-fix button? If we don't want to do that instead of the user (maybe he does not want this option activated on the datasource), maybe we could add a button to do that. |
Actually, for now, both are needed, it's not a "OR", but a "AND". One is to edit global connection, the other for current loaded layers
Everything is written, with bold : no :)
Yes, this is the idea, that's why the current group box title is |
39c4ac4
to
1e7ae19
Compare
Let's merge and let's give it a try ... |