Css changes #913
Merged
Css changes #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "emulator": "npm run dist:staging && npm run prefirebase && cd public && firebase emulators:start" | ||
| "emulator": "npm run dist:staging && npm run prefirebase && cd public && firebase emulators:start", | ||
| "build:css": "tailwindcss -i ./src/styles/tailwind.css -o ./dist/tailwind.css", | ||
| "watch:css": "tailwindcss -i ./src/styles/tailwind.css -o ./dist/tailwind.css --watch" |
There was a problem hiding this comment.
You shouldn't need the tailwindcss cli if you're using postcss-loader in the webpack config.
| @@ -9,7 +9,7 @@ import styles from './Logo.module.scss'; | |||
| * @category Components | |||
| */ | |||
| const Logo = ({ onToggleEdit, isEditor }) => ( | |||
| <div className={styles.wrapper}> | |||
| <div className="flex items-center space-x-2"> | |||
There was a problem hiding this comment.
If you use display flex, prefer using gap-2 instead of space-x-2 that uses margins on children.
| @@ -335,14 +335,12 @@ export default class SceneGraph extends React.Component { | |||
| // Outliner class names. | |||
| const className = classNames({ | |||
| outliner: true, | |||
| hide: this.state.leftBarHide | |||
| hide: this.state.leftBarHide, | |||
| 'mt-16': true | |||
There was a problem hiding this comment.
As a general note, avoid margin as much as possible, even forbid it, use padding instead if you want components to be reusable. Space between elements should be set by the parent element on its children (via flex gap for example). Here you should really modify the top value for the outliner class instead of adding a margin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
potentially negative side effects