-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New scene function #509
New scene function #509
Conversation
✅ Deploy Preview for 3dstreet-core-builds ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
what should be the initial structure of Blank Scene? Like this one?
|
I have added newScene funtion as |
now that they're productized yay!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While reviewing, I ended up refactoring the buttons to properly use the Button component.
… with sceneEl here once we will have undo/redo
similar to scene title edit modal, when the street-geo component is updated, we should also fire an event such that the react app is listening for this event and 'resets' the geo panel? |
@kfarr and I started a GeoContext on @kfarr machine. Almost finished, we just need to reset the context value after calling newScene. We will finish that Friday. |
Also probably put the "New" button behind a flag or just comment it before merging. |
@vincentfretin i committed our WIP work and tested, all seems to work with exception of resetting geo stuff as you noted so we can resume that on Fri |
Added a newScene function to clear the old scene and create an empty scene. Perhaps there is something else to consider in this function, @kfarr ?
In the next commits I will add call of this function to the appropriate places in the code.
#485