Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix audio for vllm #755

Closed
wants to merge 3 commits into from
Closed

fix audio for vllm #755

wants to merge 3 commits into from

Conversation

CallmeZhangChenchen
Copy link

  1. 支持 spk_smp
  2. 支持 txt_smp
  3. vllm refine_text 经常会多一个 [Ebreak]，导致跟基本版声音不一致

@CallmeZhangChenchen CallmeZhangChenchen mentioned this pull request Sep 14, 2024
Open
fumiama
fumiama requested changes Sep 15, 2024
View reviewed changes
Copy link
Member

@fumiama fumiama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢您的贡献，但 #746 已存在类似修改，请查看他的改动，看看是否与你实现的功能相同🤝。

ChatTTS/model/velocity/model_runner.py
@@ -77,6 +77,19 @@ def __init__(
# cache in_wsl result
self.in_wsl = in_wsl()

from ...config import Config
self.config = Config()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

很坏的解决方案，完全破坏了设置的继承依赖关系。此配置应当从外部传入，而非自己二次引入。

@fumiama fumiama added duplicate This issue or pull request already exists question Further information is requested labels Sep 15, 2024
@fumiama fumiama closed this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fumiama fumiama fumiama requested changes

Assignees
No one assigned
Labels
duplicate This issue or pull request already exists question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CallmeZhangChenchen @fumiama @callmezhangchenchenokay