feat: Implement worker threads for upload processing #1591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 322120f.
Using the file system location is much more reliable than passing around buffer.
aalemayhu
commented
Sep 1, 2024
| @@ -61,7 +61,12 @@ class DownloadController { | |||
| return; | |||
| } | |||
|
|
|||
| const page = DownloadPage({ id, files }); | |||
| console.log('files', files); | |||
|
|
|||
Do not copy apkg when not used. Due to the thread changes we do not to keep the buffer in memory.
aalemayhu
commented
Sep 1, 2024
| const page = DownloadPage({ | ||
| id, | ||
| files: files.filter((file) => file.endsWith('.apkg')), | ||
| }); |
There was a problem hiding this comment.
we do not want to index images and other files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately the node worker threads cannot share buffers reliably with the main thread. I learned this the hard way 😅
So I have move all of the read writes of the APKG payload to be be based on file system access which is thread safe since we only read after writes.
While reviewing the code path, I discovered that we actually do a lot of wasteful reads and writes. Essentially for every APKG generation we make 2x calls due to the renaming to provide the uploader with friendly name. I have not measured how long this takes but instead of double work we do this one time and rely on the create_deck having the right name.
Revert of revert #1589
Reference: 2anki/create_deck#93