Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle case where viewportHeigh is equal to heighOffset #6

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

zzhelqzkov
Copy link

@zzhelqzkov zzhelqzkov commented Sep 20, 2024

This pull request addresses an issue with the full-screen screenshot functionality when the page size exceeds the device's viewport. The problem occurs during the final screenshot, which requires cropping. A specific edge case was not handled: when the last screenshot matches the exact pixel dimensions of the device’s viewport, it results in throwing an error geometry does not contain image @ warning/transform.c/CropImage/718

@zzhelqzkov zzhelqzkov merged commit 1850f19 into master Sep 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants