Change retry logic

1FF · Sep 26, 2024 · 95aa119 · 95aa119
1 parent 1850f19
commit 95aa119
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/src/Codeception/Module/VisualCeption.php b/src/Codeception/Module/VisualCeption.php
@@ -258,6 +258,7 @@ public function dontSeeVisualChangesForViewPort(string $identifier, string $elem
      * @param $deviation
      * @param $seeChanges
      * @return void
+     * @throws \Exception
      */
     private function compareVisualChanges($identifier, $elementID, $excludeElements, $deviation, $seeChanges, $fullScreenshot = true): void
     {
@@ -274,13 +275,18 @@ private function compareVisualChanges($identifier, $elementID, $excludeElements,
         $outOfMaxDeviation = !$seeChanges && $deviationResult["deviation"] > $maximumDeviation;
 
         if ($outOfMaxDeviation) {
-            $retries = 0;
+            $startTime = time();
+            $timeout = 15;
+
+            while ($outOfMaxDeviation) {
+                if((time() - $startTime) > $timeout){
+                    throw new \Exception("Screenshots comparison failed after timeout - $timeout seconds");
+                }
 
-            while ($retries < 5 && $outOfMaxDeviation){
                 $deviationResult = $this->getDeviation($identifier, $elementID, $fullScreenshot, $excludeElements);
                 $outOfMaxDeviation = $deviationResult["deviation"] > $maximumDeviation;
-                $retries++;
-                sleep(1);
+                $this->webDriver->executeScript("window.scrollTo(0, 0);");
+                sleep(2);
             }
         }