Omit empty FormResponse errors from analytics logging #11799
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates
FormResponse#to_h
to serialize an emptyerrors
asnil
instead of{}
, effectively removing this value from logging.This serves two purposes:
errors
altogether.errors: {}
📜 Testing Plan
Verify build passes.
Verify using
make watch_events
that any event which would have previously loggederrors: {}
will now excludeerrors
from the logging payload.