Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-15392 Remove the locale param from the post-IdV follow-up URL #11781

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

LG-15392 Remove the locale param from the post-IdV follow-up URL #11781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions app/services/sp_return_url_resolver.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,7 @@ def homepage_url
end

def post_idv_follow_up_url
url = service_provider.post_idv_follow_up_url || homepage_url
return if url.blank?
format(url.to_s, locale: I18n.locale.to_s)
service_provider.post_idv_follow_up_url || homepage_url
end

private
Expand Down
8 changes: 0 additions & 8 deletions spec/services/sp_return_url_resolver_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,13 +170,5 @@

it { expect(post_idv_follow_up_url).to eq(sp_post_idv_follow_up_url) }
end

context 'with a template param in the URL' do
let(:sp_post_idv_follow_up_url) { 'https://sp.gov/follow_up?locale=%{locale}' }

it 'interpolates the appropriate value' do
expect(post_idv_follow_up_url).to eq('https://sp.gov/follow_up?locale=en')
end
end
end
end