-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LG-15337: Socure Try again
page for hybrid mobile flow
#11734
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solipet
requested review from
amirbey,
theabrad,
jmax-gsa,
gina-yamada and
AShukla-GSA
January 10, 2025 18:19
amirbey
reviewed
Jan 10, 2025
app/controllers/idv/hybrid_mobile/document_capture_controller.rb
Outdated
Show resolved
Hide resolved
amirbey
reviewed
Jan 10, 2025
app/javascript/packages/document-capture/components/in-person-prepare-step.tsx
Outdated
Show resolved
Hide resolved
jmax-gsa
requested changes
Jan 13, 2025
I was successfully directed to the start of IPP in both flows with I clicked the Try in person button. Did go back in IPP work for others in both flows? Standard flow- I was taken back to doc auth step 1. Hybrid flow- I was taken to google. |
jmax-gsa
approved these changes
Jan 15, 2025
theabrad
approved these changes
Jan 15, 2025
solipet
force-pushed
the
dprice/lg-15337-try-again-hybrid
branch
from
January 16, 2025 18:41
d3ffdb4
to
bb2af96
Compare
If the system times out waiting for the data from Socure, show the try again page with, if available, an option to switch to in person proofing. changelog: Upcoming Features, Identity Verification, Socure timeout provides hybrid users with options. This first commit sets up the page. Try again works. IPP does not work yet.
Co-authored-by: John Maxwell <[email protected]>
Co-authored-by: Gina Yamada <[email protected]>
solipet
force-pushed
the
dprice/lg-15337-try-again-hybrid
branch
from
January 16, 2025 19:46
bb2af96
to
1f22c8e
Compare
… and hybrid flows
solipet
force-pushed
the
dprice/lg-15337-try-again-hybrid
branch
from
January 16, 2025 20:02
1f22c8e
to
22759ca
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-15337
🛠 Summary of changes
Socure
Try again
page for hybrid mobile flowIf the system times out waiting for the data from Socure, show the try again page with, if available, an option to switch to in person proofing.
Try again
takes the user back to the Socure document capture page.Try in person
takes the user to the beginning of the IPP flow, part of the hybrid_mobile document capture React app.📜 Testing Plan
Setup:
timnit
orsolipet
)solipet
env:Standard flow:
/verify
to start the IdV flowTry in person
- confirm you are on the beginning of the IPP flowTry again
- confirm you are on the Socure document capture pageHybrid flow:
/verify
to start the IdV flowTry in person
- confirm you are on the beginning of the IPP flow in the hybrid_mobile document_capture controllerTry again
- confirm you are on the Socure document capture page