changelog: Internal, In-person Proofing, Remove in_person_full_addres…

…s_entry_enabled feature flag usage. (#11746)
18F · Jan 16, 2025 · 41f8d41 · 41f8d41
1 parent 82e13d3
commit 41f8d41
Show file tree

Hide file tree

Showing 12 changed files with 4 additions and 33 deletions.
diff --git a/app/javascript/packages/document-capture/components/document-capture-review-issues.spec.tsx b/app/javascript/packages/document-capture/components/document-capture-review-issues.spec.tsx
@@ -51,7 +51,6 @@ describe('DocumentCaptureReviewIssues', () => {
             inPersonURL: '/verify/doc_capture',
             locationsURL: '',
             addressSearchURL: '',
-            inPersonFullAddressEntryEnabled: false,
             inPersonOutageMessageEnabled: false,
             optedInToInPersonProofing: false,
             usStatesTerritories: [['Los Angeles', 'NY']],
@@ -125,7 +124,6 @@ describe('DocumentCaptureReviewIssues', () => {
             inPersonURL: '/verify/doc_capture',
             locationsURL: '',
             addressSearchURL: '',
-            inPersonFullAddressEntryEnabled: false,
             inPersonOutageMessageEnabled: false,
             optedInToInPersonProofing: false,
             usStatesTerritories: [['Los Angeles', 'NY']],

diff --git a/app/javascript/packages/document-capture/components/document-capture.tsx b/app/javascript/packages/document-capture/components/document-capture.tsx
@@ -10,7 +10,6 @@ import { UploadFormEntriesError } from '../services/upload';
 import SelfieStep from './selfie-step';
 import DocumentsStep from './documents-step';
 import InPersonPrepareStep from './in-person-prepare-step';
-import InPersonLocationPostOfficeSearchStep from './in-person-location-post-office-search-step';
 import InPersonLocationFullAddressEntryPostOfficeSearchStep from './in-person-location-full-address-entry-post-office-search-step';
 import InPersonSwitchBackStep from './in-person-switch-back-step';
 import ReviewIssuesStep from './review-issues-step';
@@ -39,22 +38,16 @@ function DocumentCapture({ onStepChange = () => {} }: DocumentCaptureProps) {
   const { flowPath } = useContext(UploadContext);
   const { trackSubmitEvent, trackVisitEvent } = useContext(AnalyticsContext);
   const { isSelfieCaptureEnabled } = useContext(SelfieCaptureContext);
-  const {
-    inPersonFullAddressEntryEnabled,
-    inPersonURL,
-    skipDocAuthFromHandoff,
-    skipDocAuthFromHowToVerify,
-  } = useContext(InPersonContext);
+  const { inPersonURL, skipDocAuthFromHandoff, skipDocAuthFromHowToVerify } =
+    useContext(InPersonContext);
   useDidUpdateEffect(onStepChange, [stepName]);
   useEffect(() => {
     if (stepName) {
       trackVisitEvent(stepName);
     }
   }, [stepName]);
   const appName = getConfigValue('appName');
-  const inPersonLocationPostOfficeSearchForm = inPersonFullAddressEntryEnabled
-    ? InPersonLocationFullAddressEntryPostOfficeSearchStep
-    : InPersonLocationPostOfficeSearchStep;
+  const inPersonLocationPostOfficeSearchForm = InPersonLocationFullAddressEntryPostOfficeSearchStep;
 
   // Define different states to be used in human readable array declaration
   const documentFormStep: FormStep = {

diff --git a/...capture/components/in-person-location-full-address-entry-post-office-search-step.spec.tsx b/...capture/components/in-person-location-full-address-entry-post-office-search-step.spec.tsx
@@ -54,7 +54,6 @@ describe('InPersonLocationFullAddressEntryPostOfficeSearchStep', () => {
         addressSearchURL: 'https://localhost:3000',
         inPersonOutageMessageEnabled: false,
         inPersonOutageExpectedUpdateDate: 'January 1, 2024',
-        inPersonFullAddressEntryEnabled: true,
         optedInToInPersonProofing: false,
         usStatesTerritories,
       }}

diff --git a/.../packages/document-capture/components/in-person-location-post-office-search-step.spec.tsx b/.../packages/document-capture/components/in-person-location-post-office-search-step.spec.tsx
@@ -70,7 +70,6 @@ describe('InPersonLocationPostOfficeSearchStep', () => {
         addressSearchURL,
         inPersonOutageMessageEnabled: false,
         inPersonOutageExpectedUpdateDate: 'January 1, 2024',
-        inPersonFullAddressEntryEnabled: true,
         optedInToInPersonProofing: false,
         usStatesTerritories,
       }}

diff --git a/app/javascript/packages/document-capture/components/in-person-outage-alert.spec.tsx b/app/javascript/packages/document-capture/components/in-person-outage-alert.spec.tsx
@@ -12,7 +12,6 @@ describe('InPersonOutageAlert', () => {
           addressSearchURL: 'https://localhost:3000/unused',
           inPersonOutageExpectedUpdateDate: 'January 1, 2024',
           inPersonOutageMessageEnabled: true,
-          inPersonFullAddressEntryEnabled: false,
           optedInToInPersonProofing: false,
           usStatesTerritories: [],
         }}

diff --git a/app/javascript/packages/document-capture/components/in-person-prepare-step.spec.tsx b/app/javascript/packages/document-capture/components/in-person-prepare-step.spec.tsx
@@ -41,7 +41,6 @@ describe('InPersonPrepareStep', () => {
             addressSearchURL: 'https://localhost:3000/unused',
             inPersonOutageMessageEnabled: true,
             inPersonOutageExpectedUpdateDate: 'January 1, 2024',
-            inPersonFullAddressEntryEnabled: false,
             optedInToInPersonProofing: false,
             usStatesTerritories: [],
           }}
@@ -60,7 +59,6 @@ describe('InPersonPrepareStep', () => {
             locationsURL: 'https://localhost:3000/unused',
             addressSearchURL: 'https://localhost:3000/unused',
             inPersonOutageMessageEnabled: false,
-            inPersonFullAddressEntryEnabled: false,
             optedInToInPersonProofing: false,
             usStatesTerritories: [],
           }}

diff --git a/app/javascript/packages/document-capture/context/in-person.ts b/app/javascript/packages/document-capture/context/in-person.ts
@@ -26,11 +26,6 @@ export interface InPersonContextProps {
    */
   inPersonOutageExpectedUpdateDate?: string;
 
-  /**
-   * When true users must enter a full address when searching for a Post Office location
-   */
-  inPersonFullAddressEntryEnabled: boolean;
-
   /**
    * When true a user has entered ipp by opting in
    */
@@ -70,7 +65,6 @@ const InPersonContext = createContext<InPersonContextProps>({
   locationsURL: '',
   addressSearchURL: '',
   inPersonOutageMessageEnabled: false,
-  inPersonFullAddressEntryEnabled: false,
   optedInToInPersonProofing: false,
   usStatesTerritories: [],
 });

diff --git a/app/javascript/packs/document-capture.tsx b/app/javascript/packs/document-capture.tsx
@@ -100,7 +100,6 @@ const {
   accountUrl: accountURL,
   idvInPersonUrl: inPersonURL,
   securityAndPrivacyHowItWorksUrl: securityAndPrivacyHowItWorksURL,
-  inPersonFullAddressEntryEnabled,
   inPersonOutageMessageEnabled,
   inPersonOutageExpectedUpdateDate,
   optedInToInPersonProofing,
@@ -133,7 +132,6 @@ render(
           addressSearchURL,
           inPersonOutageExpectedUpdateDate,
           inPersonOutageMessageEnabled: inPersonOutageMessageEnabled === 'true',
-          inPersonFullAddressEntryEnabled: inPersonFullAddressEntryEnabled === 'true',
           optedInToInPersonProofing: optedInToInPersonProofing === 'true',
           usStatesTerritories: parsedUsStatesTerritories,
           skipDocAuthFromHowToVerify: skipDocAuthFromHowToVerify === 'true',

diff --git a/app/views/idv/shared/_document_capture.html.erb b/app/views/idv/shared/_document_capture.html.erb
@@ -31,7 +31,6 @@
       opted_in_to_in_person_proofing: opted_in_to_in_person_proofing,
       idv_in_person_url: (IdentityConfig.store.in_person_doc_auth_button_enabled && Idv::InPersonConfig.enabled_for_issuer?(decorated_sp_session.sp_issuer)) ? idv_in_person_url : nil,
       security_and_privacy_how_it_works_url: MarketingSite.security_and_privacy_how_it_works_url,
-      in_person_full_address_entry_enabled: IdentityConfig.store.in_person_full_address_entry_enabled,
       in_person_outage_message_enabled: IdentityConfig.store.in_person_outage_message_enabled,
       in_person_outage_expected_update_date: IdentityConfig.store.in_person_outage_expected_update_date,
       us_states_territories: @presenter.usps_states_territories,

diff --git a/config/application.yml.default b/config/application.yml.default
@@ -184,7 +184,6 @@ in_person_enrollments_ready_job_max_number_of_messages: 10
 in_person_enrollments_ready_job_queue_url: ''
 in_person_enrollments_ready_job_visibility_timeout_seconds: 30
 in_person_enrollments_ready_job_wait_time_seconds: 20
-in_person_full_address_entry_enabled: true
 in_person_opt_in_available_completion_survey_url: 'https://handbook.login.gov'
 in_person_outage_emailed_by_date: 'November 1, 2024'
 # in_person_outage_expected_update_date and in_person_outage_emailed_by_date below

diff --git a/lib/identity_config.rb b/lib/identity_config.rb
@@ -210,7 +210,6 @@ def self.store
     config.add(:in_person_enrollments_ready_job_queue_url, type: :string)
     config.add(:in_person_enrollments_ready_job_visibility_timeout_seconds, type: :integer)
     config.add(:in_person_enrollments_ready_job_wait_time_seconds, type: :integer)
-    config.add(:in_person_full_address_entry_enabled, type: :boolean)
     config.add(:in_person_opt_in_available_completion_survey_url, type: :string)
     config.add(:in_person_outage_emailed_by_date, type: :string)
     config.add(:in_person_outage_expected_update_date, type: :string)

diff --git a/spec/features/idv/in_person_spec.rb b/spec/features/idv/in_person_spec.rb
@@ -393,13 +393,9 @@
     end
   end
 
-  context 'when full form address entry is enabled for post office search' do
+  context 'when full form address post office search' do
     let(:user) { user_with_2fa }
 
-    before do
-      allow(IdentityConfig.store).to receive(:in_person_full_address_entry_enabled).and_return(true)
-    end
-
     it 'allows the user to search by full address', allow_browser_log: true do
       sign_in_and_2fa_user(user)
       begin_in_person_proofing(user)