Added more accurate GPU Timing #505
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since GPUTime is used to calculate an estimated FPS, adding up all the timers doesn't paint the full picture. Instead a new timer has been added: RENDER_FRAME This timer is added at the start of postDrawScene() & ends just before the submit. (cherry picked from commit 4c4de7b)
FrameTimerOverlay::render() takes around 0.5 ms, account for this in the CPU time glGetError() is costly to call, around 0.2 ms so whilst the FrameTimer is open suppress the function
|
Noticed that both checkGlError() & rendering the FrameTimerOverlay were adding almost a whole millisecond to the CPU timer, both of these are only ever opened in developer builds, so we should try to remove them whilst the UI is opened |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
From doing GPU Captures & Traces, I've noticed that adding the GPU Markers together doesn't paint the full picture of how long a frame is being drawn. GPU Idle time,
Solution:
Added new Timer: RENDER_FRAME, to capture the time between PostDrawScene() & the Submit in Draw().
Caveat:
This does mean it'll capture the GPU Idle time between the compute & submit, but overall I've found this to be more accurate when testing changes.