Improved Readability of tileInFrustum & isOutsideViewport #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ambiguous variables names where being used making it difficult to read upon first glance, I've gone through and given them proper names, Also improved performance slightly by making tileInFrustum mirror isOutsideViewport, where variables are calculated in nested blocks to avoid unnecessary calculations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
tileInFrustum&isOutsideViewporthave all their varibles named some variant of var10, var7, var2, etc... making it difficult to read.Proposed Solution:
I've gone through and given them proper names, IE: transformedZ, leftFrustumBound, rightFrustumBound, etc.
Also improved performance slightly by making
tileInFrustummirrorisOutsideViewport, where variables are calculated in nested blocks to avoid unnecessary calculations.