Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add starknet_getMessagesStatus #621

Merged
merged 19 commits into from
Oct 11, 2024
Merged

Conversation

FabijanC
Copy link
Contributor

@FabijanC FabijanC commented Oct 4, 2024

Usage related changes

Development related changes

  • Remove dangerous use of Default::default() from try_from_message_to_l2.

Checklist:

  • Checked out the contribution guidelines
  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • No spelling errors - ./scripts/check_spelling.sh
  • Performed code self-review
  • Rebased to the latest commit of the target branch (or merged it into my branch)
    • Once you make the PR reviewable, please avoid force-pushing
  • Updated the docs if needed - ./website/README.md
  • Linked the issues resolvable by this PR - linking info
  • Updated the tests if needed; all passing - execution info

@FabijanC FabijanC marked this pull request as ready for review October 8, 2024 09:17
@FabijanC FabijanC mentioned this pull request Oct 8, 2024
7 tasks
@FabijanC FabijanC merged commit db9055b into json-rpc-v0.8.0 Oct 11, 2024
1 check passed
@FabijanC FabijanC deleted the get-messages-status branch October 11, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants