Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(multichain_payment): added new iden3message payment types #455

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from

Conversation

plusema86
Copy link
Contributor

Added the following request type:

  • Iden3PaymentRequestCryptoV1
  • Iden3PaymentRailsRequestV1
  • Iden3PaymentRailsERC20RequestV1
    Added the following payment type
  • Iden3PaymentCryptoV1
  • Iden3PaymentRailsV1
  • Iden3PaymentRailsERC20V1

plusema86 and others added 5 commits November 10, 2023 17:05
Intermediate release with Amoy network support
Added the following request type:
Iden3PaymentRequestCryptoV1
Iden3PaymentRailsRequestV1
Iden3PaymentRailsERC20RequestV1
Added the following payment type
Iden3PaymentCryptoV1
Iden3PaymentRailsV1
Iden3PaymentRailsERC20V1
@plusema86 plusema86 requested a review from 5eeman November 6, 2024 11:29
@plusema86 plusema86 self-assigned this Nov 6, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 172 lines in your changes missing coverage. Please review.

Project coverage is 20.98%. Comparing base (1cca8b5) to head (c624b98).

Files with missing lines Patch % Lines
...s/payment/response/payment_request_data_proof.dart 0.00% 44 Missing ⚠️
...n3comm/domain/entities/payment_message_entity.dart 0.00% 31 Missing ⚠️
.../response/payment_rails_erc20_request_v1_data.dart 0.00% 30 Missing ⚠️
...ayment/response/payment_rails_request_v1_data.dart 0.00% 25 Missing ⚠️
...yment/response/payment_request_crypto_v1_data.dart 0.00% 21 Missing ⚠️
...yment/response/payment_request_message_entity.dart 0.00% 21 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #455      +/-   ##
===========================================
- Coverage    21.31%   20.98%   -0.34%     
===========================================
  Files          267      271       +4     
  Lines         8744     8883     +139     
===========================================
  Hits          1864     1864              
- Misses        6880     7019     +139     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

gitguardian bot commented Nov 18, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
5525172 Triggered Generic High Entropy Secret 552de4f lib/constants.dart View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@5eeman 5eeman self-requested a review January 14, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants