Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix if a tx is finalized very fast #84

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Conversation

ARR552
Copy link
Collaborator

@ARR552 ARR552 commented Oct 31, 2024

Closes #83

What does this PR do?

This PR fixes a bug that appears if the tx is finalized or safe very fast.

Reviewers

ethtxmanager/ethtxmanager.go Outdated Show resolved Hide resolved
Copy link

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Oct 31, 2024

@ToniRamirezM ToniRamirezM merged commit 1b8de9d into main Oct 31, 2024
6 checks passed
@ToniRamirezM ToniRamirezM deleted the fix/#83_finalized_tx branch October 31, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem if tx is finalized very fast
4 participants