Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nonce too low issues fix #75

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Nonce too low issues fix #75

merged 2 commits into from
Oct 2, 2024

Conversation

Stefan-Ethernal
Copy link
Collaborator

What does this PR do?

The PR contains a set of fixes for nonce too low issues on some of the testnets.

Reviewers

Main reviewers:

@Stefan-Ethernal Stefan-Ethernal changed the title Nonce too low issues Nonce too low issues fix Oct 2, 2024
* feat: prepare txns before routines

* fix: remove forcedNonce feature

* feat: uts

* fix: lint
Copy link
Collaborator

@goran-ethernal goran-ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was already reviewed, and merged to this branch, just need to merge it to main.

Copy link

sonarcloud bot commented Oct 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
25.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@goran-ethernal goran-ethernal merged commit 3e27a39 into main Oct 2, 2024
5 of 6 checks passed
@goran-ethernal goran-ethernal deleted the zkevm branch October 2, 2024 13:46
@goran-ethernal goran-ethernal restored the zkevm branch October 3, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants