PIP36: use call over transfer in mrc20 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonDos
approved these changes
May 7, 2024
dev1644
approved these changes
May 10, 2024
dev1644
approved these changes
May 10, 2024
|
dev1644
approved these changes
May 21, 2024
dev1644
approved these changes
May 21, 2024
|
|
added MATIC > POL rename |
dev1644
approved these changes
Aug 27, 2024
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale: https://github.com/maticnetwork/Polygon-Improvement-Proposals/blob/main/PIPs/PIP-36.md
This PR updated
transfertocallduring Plasma Deposits on MRC20 (ie matic token on Polygon PoS). The updates:transferwithcall, and bubble up any reverts, fixed gas of 5000 is passed.MRC20.transfer is intentionally kept to re-use transfer, for external callers to support sending tokens to Gnosis Safe or SCW's, please use Access Lists.