Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dan/dns peer count logs #416

Closed
wants to merge 8 commits into from
Closed

Dan/dns peer count logs #416

wants to merge 8 commits into from

Conversation

rebelArtists
Copy link
Contributor

Description

add peer count logs as ddog info seems misleading

Testing

smoke tests locally working well:

11:20AM INF New peer fork_id=f097bc13 peer=enode://47b6711b99779ea411a4b39f63e4596e921845be1f58fd07258f397a4d1bd9a99b0b0f2392d47b4fc83bfdb8d44236b04b603e5ed8c8e687106a652ccd5e7186@131.153.238.202:30333 status={"ForkID":{"Hash":[240,151,188,19],"Next":0},"Genesis":"0xa9c28ce2141b56c474f1dc504bee9b01eb1bd7d1a507580d5519d4437a97de1b","Head":"0x6d9c47baa5f628b65a56905f452a3b54961fa4caefa7abf3b8a10c24334acaa8","NetworkID":137,"ProtocolVersion":68,"TD":1201269323} 11:20AM INF Current number of peers peer_count=20

@rebelArtists rebelArtists marked this pull request as ready for review October 28, 2024 10:52
Copy link
Member

@leovct leovct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@minhd-vu
Copy link
Contributor

I think navigating to localhost:2112/metrics and looking at the sensor_peers metric would be better. To me this feels redudant.

@minhd-vu minhd-vu closed this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants