ENR Parser and Monitor Fixes #111
Conversation
| if !currentlyFetchingHistoryLock.TryLock() { | ||
| return fmt.Errorf("the function is currently locked") | ||
| } | ||
| defer currentlyFetchingHistoryLock.Unlock() |
There was a problem hiding this comment.
so previously there were multiple fetches going on..?
There was a problem hiding this comment.
Yeah I believe so
fetchBlocks is called in a loop forever and by default it was always calling appendOlderBlocks. That was it's own issue. But it seemed possible that fetchBlocks -> appendOlderBlocks could be called in parallel with renderMonitorUI -> redraw -> appendOlderBlocks
I was also considering running appendOlderBlocks in a different go routined in order to avoid blocking the UI while we wait for blocks to load. If we do that then it's possible that appendOlderBlocks could be called multiple times while pressing the down arrow.
I didn't end up implementing that, but if we do it in the future it should make appendOlderBlocks work safely (I hope)
| @@ -338,7 +404,7 @@ func setUISkeleton() (blockTable *widgets.List, grid *ui.Grid, blockGrid *ui.Gri | |||
| termUi.sl3 = widgets.NewSparkline() | |||
| termUi.sl3.LineColor = ui.ColorBlue | |||
| slg3 := widgets.NewSparklineGroup(termUi.sl3) | |||
| slg3.Title = "Uncles" | |||
| slg3.Title = "Pending Tx" | |||
| @@ -145,7 +178,9 @@ func appendOlderBlocks(ctx context.Context, ms *monitorStatus, rpc *ethrpc.Clien | |||
| err := ms.getBlockRange(ctx, from, to, rpc) | |||
| if err != nil { | |||
| log.Error().Err(err).Msg("There was an issue fetching the block range") | |||
| return err | |||
Description
This PR adds the function
polycli enrwhich will parse an Ethereum ENR and convert it to enode for simpler processing.This PR also includes fixes for some panics in
polycli monitor. Additonally, we're swapping out the uncle graph for a pending transaction graph which won't be aligned with the block history, but will be more interesting to look at. This PR also includes a fix to stoppolycli monitorfrom trying to fetch blocks foreverJira / Linear Tickets
Testing
polycli p2p crawl