feat: sync UpdateL1InfoTreeV2 #145
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joanestebanr
requested changes
Oct 31, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sync the
UpdateL1InfoTreeV2event. This event shares info to be used as a sanity check. If the sanity check fails it means that the syncer failed to sync the L1 info tree in a fatal way.However this could be caused due to a reorg that has not been detected yet. In fact, one of the reorg tests was failing because of that. That's why I've implemented this in a way that halts the syncer instead of returning an error: to give the syncer the opportunity to get reorged. Note that if the sanity check fails for other reasons that are not reorg, this means that the syncer code has a fatal bug innit