Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add a 'stable' docker tag tracking official releases instead of 'latest' #2350

Closed
phipolis opened this issue Apr 4, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@phipolis
Copy link

phipolis commented Apr 4, 2022

Is your feature request related to a problem? Please describe.
In #2349 I experienced a situation where the latest tag updated with commits to the master branch, breaking my installation when I pulled the new image. When I went to check if there was a new release, the last versioned release in github as well as the last version-tagged docker image was 6.6.2, 10 days previous.

I was confused then about what had changed until I dug into the commit history and saw that latest corresponded to a major change merged into master but not yet tagged and released. The Zwavejs2mqtt documentation states docker tags tags include "latest for the latest official release" and "master for the bleeding edge version". Therefore it seems the latest tag was changed in error.

Describe the solution you'd like
The consensus seems to be the latest tag is tricky and best avoided, and an alternative I've seen (e.g. in projects such as HomeAssistant) is to maintain a separate stable tag that tracks the latest official release. That avoids accidental tagging of latest in favor of a custom tag that only gets updated by CI in response to a github release.

Describe alternatives you've considered
This may reasonably be considered a bug that latest is tracking updates to master rather than the latest stable release as advertised. Preventing that would also work. But as the article above mentions, it can be very difficult to always prevent latest from getting updated at the wrong time.

@phipolis phipolis added the enhancement New feature or request label Apr 4, 2022
@RichFoley
Copy link

Shouldn't only numbered releases get the 'latest' tag? This broke things for me today too.

@robertsLando
Copy link
Member

In latest releases I change the docker meta action that is responsable to create the required tags based on the event that triggers the workflow. I will fix this ASAP to just update latest when there is a new version release

@robertsLando
Copy link
Member

Fixed by bcf8f44

@robertsLando
Copy link
Member

I'm really sorry for the issues you are having with latest tag, seems the problem is related to serialport module not working on some archs with docker, follow updates here: #2349

@phipolis
Copy link
Author

phipolis commented Apr 5, 2022

@robertsLando Many thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants