Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try using same fonts in content as Zulip web #163

Closed
gnprice opened this issue Jun 8, 2023 · 1 comment
Closed

Try using same fonts in content as Zulip web #163

gnprice opened this issue Jun 8, 2023 · 1 comment
Labels
a-content Parsing and rendering Zulip HTML content, notably message contents

Comments

@gnprice
Copy link
Member

gnprice commented Jun 8, 2023

This is a continuation of #64. That issue was about both an experiment to do to exercise features of Flutter, and a user-facing change to try in the app. We did the experiment and closed the issue, but the user-facing change remains open.

Adapting that issue's description:

Zulip web uses the font Source Sans 3 for most text, and Source Code Pro for code blocks and code spans.

Currently, in much of zulip-flutter as well as in the zulip-mobile RN app, we use system fonts. This has advantages but also disadvantages:

Since #94, we use Source Code Pro for code blocks and code spans, but continue to use system fonts for the rest of the text.

It would be neat to try using the same fonts as on web, for the entire content of messages. Probably for the rest of the message list too: recipient headers, dates, etc.

@gnprice gnprice added the a-content Parsing and rendering Zulip HTML content, notably message contents label Jun 8, 2023
@gnprice gnprice added this to the Launch milestone Jun 8, 2023
@gnprice gnprice modified the milestones: Launch, Beta Sep 22, 2023
@gnprice gnprice modified the milestones: Beta 1, Beta 2 Nov 8, 2023
@chrisbobbe
Copy link
Collaborator

I think this issue is fixed:

This bit isn't yet taken care of:

Probably for the rest of the message list too: recipient headers, dates, etc.

But I assume it will be naturally when we address

.

So, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-content Parsing and rendering Zulip HTML content, notably message contents
Projects
Status: Done
Development

No branches or pull requests

2 participants