Use max_message_length instead of hardcoded limit of 10000

[chrisbobbe]

We currently use a constant kMaxMessageLengthCodePoints. We should instead use max_message_length from the server; search for max_message_length at https://zulip.com/api/register-queue

Related issues

• Use max_topic_length instead of hardcoded limit of 60 #307

[Spyyy004]

Hey, I am working on it. I have successfully fetched the max_message_length from the server and added it in the models. I am now working on integrating it with the compose_box widget.

[Spyyy004]

Update : I did the integration with the sendbutton widget error checker function successfully but somehow i cant raise a PR now. Whenever i try to push the code to origin, it is giving me 403 error.

[apoorvapendse]

Hey @Spyyy004, what is the url for the origin alias in your case?
Maybe it has something to do with that.

[Spyyy004]

remote: Permission to zulip/zulip-flutter.git denied to Spyyy004.
fatal: unable to access 'https://github.com/zulip/zulip-flutter.git/': The requested URL returned error: 403

[apoorvapendse]

can you run git remote get-url origin and paste the output.
I think that is where the issue is.
Also could you link the PR for this?

[Spyyy004]

Output of the command : https://github.com/zulip/zulip-flutter.git

I am unable to raise a PR because I am unable to push the code to origin on my branch.

[apoorvapendse]

Oh, that's where the problem is:
Your origin is set to https://github.com/zulip/zulip-flutter instead of your fork.

You first need to fork zulip-flutter and then clone your fork.
Running git clone https://github.com/Spyyy004/zulip-flutter should do the trick if you forked it correctly.
Create a local feature branch using git checkout -b <branch name>.
Then make the changes on this cloned copy.
And then commit and push to your fork which is generally aliased with origin.
And finally create a PR on upstream.

You can see this short video to get a better understanding of how to do it.
https://youtu.be/v2X51AVgl3o?feature=shared&t=221

[Spyyy004]

Oh so i need to work on a forked repository. Got it. Thanks for the help

[Spyyy004]

Here is the PR : #1267

[apoorvapendse]

Awesome!
Follow Zulip's commit discipline to frame your commits and then ask for a review on https://chat.zulip.org in the #mobile-dev-help channel.