Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

httpClientSessionInit does not return rc/rsn to callers #443

Open
1000TurquoisePogs opened this issue Apr 19, 2024 · 2 comments
Open

httpClientSessionInit does not return rc/rsn to callers #443

1000TurquoisePogs opened this issue Apr 19, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request new not yet triaged

Comments

@1000TurquoisePogs
Copy link
Member

httpClientSessionInit has its own set of status values it returns, but the actual rc/rsn of commands it does within are hidden behind compile-time printf statements.

This is unhelpful because this function does fail sometimes, and on zOS the reason is opaque and requires a GSK trace to then discover the cause. It just costs extra debug time then.

Is there any opposition to just add more arguments to httpClientSessionInit to allow passing back rc/rsn?

https://github.com/zowe/zowe-common-c/blob/v2.x/staging/c/httpclient.c#L652

@1000TurquoisePogs 1000TurquoisePogs added enhancement New feature or request new not yet triaged labels Apr 19, 2024
@JoeNemo JoeNemo self-assigned this Apr 24, 2024
@JoeNemo
Copy link
Contributor

JoeNemo commented Apr 24, 2024

If @DivergentEuropeans or @Gautham-coder want this one to fix, please take it. It's probably not hard.

@Gautham-coder
Copy link
Contributor

I will take it up Joe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new not yet triaged
Projects
None yet
Development

No branches or pull requests

3 participants