-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please bump the Golang version to a modern one #440
Comments
@phillip-stephens thoughts? |
Yeah we should def do this. I started it here, but something is going wrong in the integration tests. I need to take some time and figure out how these integration tests are working to know what I broke. 😭 |
Do these tests pass with the current master, without changes? I vaguely recall there being some issues with CI though I don't recall of they were specifically related to validation of the output against the schemas Something to check, before you bang your head too much against the wall 😊 |
@phillip-stephens I just realized I did a similar thing as you in #461, but integration tests pass just fine there. Looking at your own PR, it looks pretty much all the containers failed on crypto related items (you'll see errors in docker container execution). Since you didn't change any of them, perhaps a failure stemming from whatever was running the integration tests, rather than an issue with the change itself? |
I added a note to the test failure, in case it saves you a few minutes in identifying where the actual ERROR is Seems like a NULL value is not being serialized/deserialized from a |
Closed with #461. Thanks @Seanstoppable ! |
here
Errors:
The text was updated successfully, but these errors were encountered: