Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests #35

Closed
Divide-By-0 opened this issue Nov 24, 2023 · 1 comment
Closed

Add tests #35

Divide-By-0 opened this issue Nov 24, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed high

Comments

@Divide-By-0
Copy link
Member

For the regex generation flow, add a few sample regexes or regex configs, then generate a final circom file and use circom-tester to ensure that it in fact correctly matches that regex and reveals the right group. This will be needed to merge in #31.

@Divide-By-0 Divide-By-0 added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed high labels Nov 24, 2023
@SoraSuegami
Copy link
Contributor

The generated circuits are already tested here.
https://github.com/zkemail/zk-regex/tree/main/packages/circom/tests
Those tests automatically generate the circom circuits for the regexes in the circom package and check the revealed substrings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed high
Projects
None yet
Development

No branches or pull requests

2 participants