Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS -> TS #18

Closed
Divide-By-0 opened this issue Sep 28, 2023 · 6 comments
Closed

JS -> TS #18

Divide-By-0 opened this issue Sep 28, 2023 · 6 comments
Assignees
Labels

Comments

@Divide-By-0
Copy link
Member

Convert our main files from JS to TS to make them safer and more readable.

@SneakY-NickY
Copy link
Contributor

Hi, I'm here from #24. Could you please assign me to this issue?

@SneakY-NickY
Copy link
Contributor

SneakY-NickY commented Oct 13, 2023

I'm having issues installing dependencies for this project using yarn install. For some odd reason, it's trying to look for a module inside:

C:\Users\Martin\Desktop\zk-regex\node_modules\node_modules\cargo-cp-artifact\bin\cargo-cp-artifact.js

When the correct path should be:

C:\Users\Martin\Desktop\zk-regex\node_modules\cargo-cp-artifact\bin\cargo-cp-artifact.js

image

Any way I could possibly fix this myself?

@SneakY-NickY
Copy link
Contributor

I've tried using npm/npm run as a replacement for yarn and everything seems to work. Still a bit weird since both should be doing the same thing afaik.

@Divide-By-0
Copy link
Member Author

Divide-By-0 commented Oct 29, 2023

@SneakY-NickY we've pushed some updates. let us know if the new build works! can we see your WIP PR?

@SneakY-NickY
Copy link
Contributor

SneakY-NickY commented Oct 30, 2023

That's great to hear! I'll try it out tomorrow and show you the WIP as well. Also, sorry for a bit late reply 😅

@SneakY-NickY
Copy link
Contributor

@SneakY-NickY we've pushed some updates. let us know if the new build works! can we see your WIP PR?

I've tried out the new build and unfortunately got the same errors 😢

Here's the WIP PR 😄 : #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants