Ping results in switch state stuck "on"

[patrickhpan]

The ping method updates the internal state to !error each time the device pings, resulting in the state being constantly set to "on". Thus, when HomeKit gets the device state, it always sees "on", even if the device is switched off. Due to internal checks on only setting device state if the new state is different, only attempting to turn off the device will work at that point, even if the device is already off.

homebridge-switchbot-for-mac/src/accessory.ts

Line 174 in 23f15e3

this.updateState(!error);

[zizi4n5]

The ping option will not work properly for devices that ping successfully when the device is powered off.
Therefore, do not set the ping option in such a case.

If the ping succeeds, !error is true, so state will be on.
If the ping is fails, !error is false, so state will be off.

[joslau]

I have same issue using bot w/o hub,
but i ping 192.168.0.1 (non-existent IP) to get the state to off.

[zizi4n5]

Could it be the same problem as the following?
#20

The ping option is only available if you can use ping to determine whether a device is on or off.
Set the ipAddress of the target device, not "127.0.0.1".

Otherwise, remove the ping option.