Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Bitcoin with Protocol contract v2 architecture #2711

Open
Tracked by #2745
lumtis opened this issue Aug 15, 2024 · 1 comment · May be fixed by #3426
Open
Tracked by #2745

Support Bitcoin with Protocol contract v2 architecture #2711

lumtis opened this issue Aug 15, 2024 · 1 comment · May be fixed by #3426
Assignees
@lumtis
Labels
chain:bitcoin Bitcoin chain related zetaclient Issues related to ZetaClient

Comments

@lumtis
Copy link
Member

lumtis commented Aug 15, 2024 •
edited
Loading

Describe the Issue

  • Define some logic allow to set ProtocolContractVersions == 2 in the vote inbound in inbound.go
  • Set the correct message: the message passed in VoteInbound is not the message itself, it doesn't contains the receiver as first few bytes anymore, this parsing should be done at the ZetaClient level
  • Add E2E test to check Deposit and DepositAndCall

IMPORTANT: Bitcoin should still use the Origin field for the context for calls has the sender field (ethaddress) can't contains the address : #3018 (comment)
@lumtis lumtis added the zetaclient Issues related to ZetaClient label Aug 15, 2024
This was referenced Aug 15, 2024
Open
Open
@lumtis lumtis self-assigned this Aug 28, 2024
@lumtis lumtis added the chain:bitcoin Bitcoin chain related label Oct 4, 2024
@lumtis lumtis mentioned this issue Oct 4, 2024
Open
@coderabbitai coderabbitai bot mentioned this issue Oct 22, 2024
Merged
10 tasks
@skosito skosito mentioned this issue Nov 20, 2024
Merged
5 tasks
@lumtis
Copy link
Member Author

lumtis commented Jan 23, 2025

Will wait on #3358 before starting it. Basically if the receiver address is not correctly formatted in the Bitcoin observation, this would results in an "invalid observation" that would reverts the funds to the user

@lumtis lumtis linked a pull request Jan 28, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lumtis lumtis

Labels
chain:bitcoin Bitcoin chain related zetaclient Issues related to ZetaClient
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: use protocol contracts V2 with Bitcoin deposits zeta-chain/node
1 participant
@lumtis