Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AUTOREV in zeroc recipes? #2

Open
ssfivy opened this issue Jul 17, 2020 · 4 comments
Open

AUTOREV in zeroc recipes? #2

ssfivy opened this issue Jul 17, 2020 · 4 comments

Comments

@ssfivy
Copy link

ssfivy commented Jul 17, 2020

Hello,

I noticed that the source revision uses AUTOREV instead of fixed revisions on these files:

  • zeroc-ice_3.7.3.bb
  • zeroc-ice_3.7.4.bb

Is this intentional? I would expect recipes with fixed version numbers to contained fixed git revision. Both zeroc-ice_3.7.0.bb and zeroc-ice_3.7.1.bb seem to contain fixed revisions too.

@externl
Copy link
Member

externl commented Jul 17, 2020

Yes, you're right. I think we unintentionally copied AUTOREV from our zeroc-ice_3.7.bb formula after releasing. These fixed releases should use the commit hash.

@ssfivy
Copy link
Author

ssfivy commented Jul 17, 2020

Okay, so only the zeroc-ice_3.7.bb file is supposed to use AUTOREV for those who always want the latest version. Also in this file I noticed:

PV = "3.7.3+git${SRCPV}"

should this be:

PV = "3.7+git${SRCPV}"

?

@externl
Copy link
Member

externl commented Jul 17, 2020

I think the issue is with version priority, but I don't quite remember. Since Ice 3.7.4 is out it should at least be:
PV = "3.7.4+git${SRCPV}"

@pepone do you remember?

@pepone
Copy link
Member

pepone commented Jul 17, 2020

I think the issue is with version priority, but I don't quite remember. Since Ice 3.7.4 is out it should at least be:
PV = "3.7.4+git${SRCPV}"

@pepone do you remember?

PV = "3.7.4+git${SRCPV}" sounds right to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants