forgotten IS_ENABLED(CONFIG_SHELL_LOG_BACKEND) condition #69555
Assignees
Labels
Comments
|
Hi @lukas-fwdev! We appreciate you submitting your first issue for our open-source project. 🌟 Even though I'm a bot, I can assure you that the whole community is genuinely grateful for your time and effort. 🤖💙 |
jakub-uC
added a commit
to jakub-uC/zephyr
that referenced
this issue
Feb 29, 2024
Added missing condition to check if log backend is configured before calling the function: z_shell_log_backend_disable. Without this, in some configurations, a compilation error appeared due to calling a non-existent function. Fixes: zephyrproject-rtos#69555 Signed-off-by: Jakub Rzeszutko <[email protected]>
|
@lukas-fwdev Thank you for your finding. |
aescolar
pushed a commit
that referenced
this issue
Mar 4, 2024
Added missing condition to check if log backend is configured before calling the function: z_shell_log_backend_disable. Without this, in some configurations, a compilation error appeared due to calling a non-existent function. Fixes: #69555 Signed-off-by: Jakub Rzeszutko <[email protected]>
ashiroji
pushed a commit
to ashiroji/zephyr
that referenced
this issue
Mar 19, 2024
Added missing condition to check if log backend is configured before calling the function: z_shell_log_backend_disable. Without this, in some configurations, a compilation error appeared due to calling a non-existent function. Fixes: zephyrproject-rtos#69555 Signed-off-by: Jakub Rzeszutko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As described here: #69553
in the call of z_shell_log_backend_disable() inside shell_stop function (in zephyr/subsys/shell/shell.c) which was introduced with PR #67400 from @jakub-uC a condition surrounding the call is missing.
It needs to be
if (IS_ENABLED(CONFIG_SHELL_LOG_BACKEND)) { z_shell_log_backend_disable(sh->log_backend); }With the state of v3.6.0 release, building without the CONFIG_SHELL_LOG_BACKEND' is not possible.
The text was updated successfully, but these errors were encountered: