Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llext: STT_OBJECT relocations incorrectly ignored #67701

Closed
teburd opened this issue Jan 16, 2024 · 0 comments · Fixed by #69432
Closed

llext: STT_OBJECT relocations incorrectly ignored #67701

teburd opened this issue Jan 16, 2024 · 0 comments · Fixed by #69432
Assignees
@laurenmurphyx64
Labels
area: ARM ARM (32-bit) Architecture area: llext Linkable Loadable Extensions bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@teburd
Copy link
Collaborator

teburd commented Jan 16, 2024 •
edited
Loading

STT_OBJECT symbol relocations are ignored silently currently and this leads to confusing bugs where a global (non-static) is declared in an extension leading to invalid memory addresses to the global symbol once the extension loads on Arm.

Primarily this is because on Arm we are doing static linking currently I believe.

So don't ignore STT_OBJECT relocations, and certainly don't do it silently

Thanks @laurenmurphyx64 for hunting this down
@teburd teburd added the bug The issue is a bug, or the PR is fixing a bug label Jan 16, 2024
@teburd teburd self-assigned this Jan 16, 2024
@teburd teburd added area: llext Linkable Loadable Extensions area: ARM ARM (32-bit) Architecture labels Jan 16, 2024
@teburd teburd modified the milestone: future Jan 16, 2024
@teburd teburd added the priority: low Low impact/importance bug label Jan 16, 2024
@laurenmurphyx64 laurenmurphyx64 mentioned this issue Feb 25, 2024
Merged
laurenmurphyx64 added a commit to laurenmurphyx64/zephyr that referenced this issue Mar 14, 2024
@laurenmurphyx64
llext: add STT_OBJECT relocation
8bcf9ab 
Adds STT_OBJECT relocation.

Fixes zephyrproject-rtos#67701.

Signed-off-by: Lauren Murphy <[email protected]>
ashiroji pushed a commit to ashiroji/zephyr that referenced this issue Mar 19, 2024
@laurenmurphyx64 @ashiroji
llext: add STT_OBJECT relocation
82a62dd 
Adds STT_OBJECT relocation.

Fixes zephyrproject-rtos#67701.

Signed-off-by: Lauren Murphy <[email protected]>
@laurenmurphyx64 laurenmurphyx64 mentioned this issue Apr 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laurenmurphyx64 laurenmurphyx64

Labels
area: ARM ARM (32-bit) Architecture area: llext Linkable Loadable Extensions bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

llext: add STT_OBJECT relocation laurenmurphyx64/zephyr
2 participants
@teburd @laurenmurphyx64