Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: ppp: doc: PPP documentation page ('connectivity/networking/api/ppp') needs updating #67171

Closed
kartben opened this issue Jan 3, 2024 · 2 comments · Fixed by #67252
Closed

net: ppp: doc: PPP documentation page ('connectivity/networking/api/ppp') needs updating #67171

kartben opened this issue Jan 3, 2024 · 2 comments · Fixed by #67252
Assignees
@jukkar
Labels
area: Documentation area: Networking bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@kartben
Copy link
Collaborator

kartben commented Jan 3, 2024

Describe the bug

Spotted two issues with PPP documentation page while looking for dead links in the documentation:

Environment

  • Page: connectivity/networking/api/ppp
  • Version: main
  • SHA-1: 69d19ae
@kartben kartben added area: Networking area: Documentation bug The issue is a bug, or the PR is fixing a bug labels Jan 3, 2024
jukkar added a commit to jukkar/zephyr that referenced this issue Jan 5, 2024
@jukkar
doc: net: ppp: Fix the point-to-point documentation
ab44ce9 
The ppp doc was still referring to gsm-modem sample which
is no longer there. Also removed old information that is no
longer relevant.

Fixes zephyrproject-rtos#67171

Signed-off-by: Jukka Rissanen <[email protected]>
@jukkar jukkar mentioned this issue Jan 5, 2024
Merged
jukkar added a commit to jukkar/zephyr that referenced this issue Jan 5, 2024
@jukkar
doc: net: ppp: Fix the point-to-point documentation
669f944 
The ppp doc was still referring to gsm-modem sample which
is no longer there. Also removed old information that is no
longer relevant.

Fixes zephyrproject-rtos#67171

Signed-off-by: Jukka Rissanen <[email protected]>
jukkar added a commit to jukkar/zephyr that referenced this issue Jan 8, 2024
@jukkar
doc: net: ppp: Fix the point-to-point documentation
ecb2ffe 
The ppp doc was still referring to gsm-modem sample which
is no longer there. Also removed old information that is no
longer relevant.

Fixes zephyrproject-rtos#67171

Signed-off-by: Jukka Rissanen <[email protected]>
@MaureenHelm MaureenHelm added the priority: low Low impact/importance bug label Jan 9, 2024
@cfriedt
Copy link
Member

cfriedt commented Jan 9, 2024

@jukkar - a really long time ago, I had a development branch that moved HDLC to its own library, since it can be used even without the IP layer. I know of one product that used that over a board-level uart connection, but that's mainly it.

The nice thing about a library implementation is that it can be separately tested. Would that be a worthwhile change?

@jukkar
Copy link
Member

jukkar commented Jan 10, 2024

The nice thing about a library implementation is that it can be separately tested. Would that be a worthwhile change?

Sure, that sounds like a good change, please submit to upstream for a review.

carlescufi pushed a commit that referenced this issue Jan 10, 2024
@jukkar @carlescufi
doc: net: ppp: Fix the point-to-point documentation
b0dd9a2 
The ppp doc was still referring to gsm-modem sample which
is no longer there. Also removed old information that is no
longer relevant.

Fixes #67171

Signed-off-by: Jukka Rissanen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jukkar jukkar

Labels
area: Documentation area: Networking bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update the ppp documentation jukkar/zephyr
4 participants
@kartben @cfriedt @jukkar @MaureenHelm