Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is Dart support still WIP? #48

Closed
temeddix opened this issue Sep 29, 2024 · 3 comments
Closed

Is Dart support still WIP? #48

temeddix opened this issue Sep 29, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@temeddix
Copy link

temeddix commented Sep 29, 2024

🚀 Feature Request

We have a demand of using Rust with Dart at Rinf. Is Dart support in serde-reflection still experimental? If it is, what can I do to make it stable?

Motivation

Is your feature request related to a problem? Please describe.

It looks like Dart support has been present from a long time ago(3 years~), but it is still not marked as stable.

Pitch

Describe the solution you'd like

Dart support being stable.

Describe alternatives you've considered

At Rinf, we are using Protobuf to send messages between Dart and Rust, but using serde will be much more elegant.

Are you willing to open a pull request? (See CONTRIBUTING)

Yes

Additional context

@temeddix temeddix added the enhancement New feature or request label Sep 29, 2024
@temeddix temeddix mentioned this issue Sep 29, 2024
@jerel
Copy link
Contributor

jerel commented Sep 29, 2024

We are still using it (in a large project) several years later and it's feature complete in my opinion. Whether it's officially listed in the README as stable is more of an administrative and maintenance decision by the repo owner.

@ma2bd
Copy link
Contributor

ma2bd commented Sep 29, 2024

Great to hear from your experience @jerel.

Technically, we're actually missing something: the support of maps and the more comprehensive e2e tests test_dart_{bcs,bincode}_runtime_on_supported_types in dart_runtime.rs.

There was a task for this in the old repository: novifinancial/serde-reflection#120

@ma2bd
Copy link
Contributor

ma2bd commented Sep 29, 2024

Just made a new task in this repo: #49

Closing this one now. We can continue the technical discussion on #49

@ma2bd ma2bd closed this as not planned Won't fix, can't repro, duplicate, stale Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants