Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve node registration forbidding inaccessible addresses #144

Open
vdelendik opened this issue Mar 14, 2024 · 0 comments
Open

improve node registration forbidding inaccessible addresses #144

vdelendik opened this issue Mar 14, 2024 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@vdelendik
Copy link
Contributor

below you can find an example when node register itself using internal ip which are not accessible by grid. as result all grid becomes broken and due to the limited number of invalid appiums all infra for automation is down.

06:24:29.075 INFO [STFClient.disconnectAllDevices] - [STF] All devices previously reserved for automation will be disconnected in STF.
06:24:30.792 INFO [DefaultGridRegistry.add] - Registered a node http://192.168.88.99:8000
06:24:30.793 INFO [DefaultGridRegistry.add] - Registered a node http://192.168.88.99:8003
06:24:30.822 INFO [DefaultGridRegistry.add] - Registered a node http://192.168.88.99:8001
06:24:30.832 INFO [DefaultGridRegistry.add] - Registered a node http://192.168.88.99:8002

let's review node registration process and fix for sure in selenium3 making extra verification in advance before registering...
also let's emulate the same issue for selenium4 grid

@vdelendik vdelendik added the enhancement New feature or request label Mar 14, 2024
@vdelendik vdelendik added this to the 2.5 milestone Mar 14, 2024
@akamarouski akamarouski modified the milestones: 2.5, 2.6 Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants