Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expander improvements I #74

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Expander improvements I #74

wants to merge 12 commits into from

Conversation

JensOgorek
Copy link
Contributor

@JensOgorek JensOgorek commented Sep 30, 2024 •
edited
Loading

This is from #18

  • Wait for full ESP Boot Dump to be written -> Delay at start.
  • Move "Ready." msg infront of main loop
  • Added reboot command to 2-pin-expander
  • Added "is_ready" property for expander
  • Added indefinite waiting from expander module for waiting msg [1. Point from Improve integration of expander module #18]
  • Added "boot_wait_time" Parameter for indefinite waiting or waiting with timeout [3. Point from Improve integration of expander module #18]
  • Added check for Proxy if Expander is ready
  • Added new Property to proxy, to see if proxied properties were created. The older "hotfix" properties could not get used for safe checks, but this one is.[2. Point from Improve integration of expander module #18]
  • fix crashes
  • fix expander module not reading the "ready" signal.

@JensOgorek JensOgorek added the enhancement New feature or request label Sep 30, 2024
@JensOgorek JensOgorek self-assigned this Sep 30, 2024
@JensOgorek JensOgorek linked an issue Sep 30, 2024 that may be closed by this pull request
Improve integration of expander module #18
Open
7 tasks
@JensOgorek JensOgorek added this to the 0.6.0 milestone Oct 23, 2024
@JensOgorek JensOgorek changed the title Expander improvements Expander improvements I Oct 23, 2024
@JensOgorek
Copy link
Contributor Author

Delaying the main task is generally not a good idea. If it is delayed too long, the esp watchdog will trigger and will reset the esp.
The solution is to initiate the expander module and not wait for the expander in the initialization. But check regularly if the expander itself is ready. If it is, the expander module will be set ready, and will be able to handle proxies, for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JensOgorek JensOgorek

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

Improve integration of expander module
1 participant
@JensOgorek