bug(macos/brew): import error on fresh homebrew install

[sweetkane]

Homebrew 4.2.12

$ brew install yurijmikhalevich/tap/rclip
$ rclip "cat"
---
Traceback (most recent call last):
  File "/opt/homebrew/bin/rclip", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/opt/homebrew/Cellar/rclip/1.7.25/libexec/lib/python3.11/site-packages/rclip/main.py", line 205, in main
    arg_parser = helpers.init_arg_parser()
                 ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/rclip/1.7.25/libexec/lib/python3.11/site-packages/rclip/utils/helpers.py", line 144, in init_arg_parser
    if is_mps_available():
       ^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/rclip/1.7.25/libexec/lib/python3.11/site-packages/rclip/utils/helpers.py", line 153, in is_mps_available
    import torch.backends.mps
ModuleNotFoundError: No module named 'torch'

[sandronm]

Same here :/

(Homebrew 4.2.17, MacOS Sonoma 14.4.1 on M1 Max)

[yurijmikhalevich]

@sweetkane, thank you for the report. Fixing.

[yurijmikhalevich]

@sweetkane, @sandronm, @xvvvyz, @came, @Alkapims, the issue should be fixed after you upgrade rclip installed with brew to the latest version: brew update && brew upgrade

Let me know if you still have it.

[sandronm]

Confirmed, it works. Thank you Le mar. 9 avr. 2024 à 13:04, Yurij Mikhalevich ***@***.***> a écrit :

…

@sweetkane <https://github.com/sweetkane>, @sandronm <https://github.com/sandronm>, @xvvvyz <https://github.com/xvvvyz>, @came <https://github.com/came>, @Alkapims <https://github.com/Alkapims>, the issue should be fixed after you upgrade rclip installed with brew to the latest version: brew update && brew upgrade Let me know if you still have it. — Reply to this email directly, view it on GitHub <#98 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEG537MIC7MHYP2ERLT7TUTY4PDMFAVCNFSM6AAAAABEURMX2CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBUGY4DQNRTGU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[timersys]

Not for me. I installed rclip and I get:
Traceback (most recent call last):
File "/opt/homebrew/bin/rclip", line 5, in
from rclip.main import main
File "/opt/homebrew/Cellar/rclip/1.10.3/libexec/lib/python3.12/site-packages/rclip/main.py", line 13, in
from rclip import db, fs, model
File "/opt/homebrew/Cellar/rclip/1.10.3/libexec/lib/python3.12/site-packages/rclip/model.py", line 10, in
import open_clip
File "/opt/homebrew/Cellar/rclip/1.10.3/libexec/lib/python3.12/site-packages/open_clip/init.py", line 3, in
from .coca_model import CoCa
File "/opt/homebrew/Cellar/rclip/1.10.3/libexec/lib/python3.12/site-packages/open_clip/coca_model.py", line 3, in
import torch
ModuleNotFoundError: No module named 'torch'
Then I did brew update && brew upgrade but I still get the same error

[yurijmikhalevich]

@timersys, thank you for flagging! I see what's up. Homebrew updated their torch to a version that uses Python 3.13, and rclip expects 3.12. Will fix.

We will need a way to keep these in sync for homebrew version.

[timersys]

@yurijmikhalevich any news on this? Is there no a way to lock the version such as composer dependencies does? so you can lock the torch version needed.

[yurijmikhalevich]

@timersys, we can lock rclip's Python version in brew, but we can't lock torchs Python version in brew – they made it depend on the latest Python. If there is a disconnect between the two rclip fails.

I am updating rclip Python dep to fix this short term and will think of a long term solution. Maybe, we can have a forked torch formula with a fixed version for rclip tap.

As a workaround, you can install rclip with pip install rclip

[yurijmikhalevich]

@timersys, a fixed version of rclip was released to brew. Can you do brew update && brew upgrade and let me know if it fixes this for you?

Sorry about the bad experience, and thank you for flagging this! 🙌

To prevent this from happening again, I have moved "brewed" rclip to its own versions of pytorch and torchvision.

To further harden the brewed rclip (and other rclip distributions), I'll do the following:

• fix(brew): brew version of rclip shouldn't depend on brew-provided versions of Python packages because this increases the likelihood of it breaking due to these packages updates #159
• ci: run tests on every distribution of rclip for every target platform every 12 hours to catch issues related to the environment changes ASAP #161
• ci: run every rclip build through rclip tests in CI on every target platform before the release to ensure every rclip build works as expected #160

[timersys]

@yurijmikhalevich Excellent job. It sworking and also the pip version.

[yurijmikhalevich]

@timersys, thank you for confirming!