-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wait until QUnit is loaded, before checking for it in inject.js. #45
base: master
Are you sure you want to change the base?
Conversation
Hm, are you using the latest version of QUnit (v1.11.0)? I've only been able to reproduce the issue in #44 using the latest version, since it works fine with the bundled version of QUnit in Yeti right now (v1.10.0), though the part of It looks like the underlying issue is the changes to QUnit's way of handling asynchronous tests, as seen in their changelog. This issue (qunitjs/qunit#314), and the start/init issues related to that one are the main cause of the problems in the newer version. I do agree with the decision that the QUnit team chose to handle that issue, though. From what I've tried out so far, there's other ways of solving the problem, but most of it involves messing with QUnit internals, which isn't too great. I'd support merging this in for now, and opening up an issue with the QUnit team to discuss a better way of handling |
Yes, I was trying the latest one. But any idea why YUI's |
I believe it's because Another possible solution would be to set @reid probably has more knowledge about me about that, and I'd also definitely love to hear his input on this. |
@clarle All of the modules Yeti needs should be already be on the page. It wouldn't hurt to set For reference: http://yuilibrary.com/yui/docs/api/classes/config.html#property_bootstrap We should have |
yeti is broken for QUnit, please release this fix ASAP. |
I thought I'd bring that bunyip fork of mine to a sane state (Yeti + Sauce Labs or BrowserStack, including local casual testing or in Travis CI) after all, but the problem described in the original pull request still persists. Do you plan to resolve it somehow? Btw, may I ask you for a comment? From my everyday perspective something like bunyip might be useful, but it is interesting what do you guys think about it, since you obviously got a wider view on the whole thing? Maybe there's a simpler way and it doesn't worth it? |
First, I do not expect this to be pulled in, since it is a wrong way to do this anyway. Initial idea was to run this code only if QUnit framework is detected below, but for some reason:
runs after
window.onload
(huh) and then it is obviously too late to stop QUnit from auto-starting.Quick and dirty way to fix: #44.
This works because autostart is requested by QUnit on window.load as well.