Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

anonymous access when reading google cloud storage #213

Open
samster25 opened this issue Nov 22, 2023 · 6 comments
Open

anonymous access when reading google cloud storage #213

samster25 opened this issue Nov 22, 2023 · 6 comments

Comments

@samster25
Copy link

samster25 commented Nov 22, 2023 •
edited
Loading

Hi! We would like to leverage anonymous access when reading from a gcs bucket as specified here. In daft, we are currently are falling back on the S3 api when no credentials are provided.

An example of this in another API is the python GCSFS project which allows the user to set the token='anon'

no authentication is performed, and you can only access data which is accessible to allUsers
@yoshidan yoshidan mentioned this issue Nov 30, 2023
Merged
@yoshidan
Copy link
Owner

Sorry for the late reply. This PR will allow anonymous access.
#217

@samster25
Copy link
Author

@yoshidan This looks great! Thank you for the quick turnaround. I'll give the PR a try in our codebase and see if it works

@samster25
Copy link
Author

Looks like our GCS tests pass in anonymous mode in this PR

@yoshidan
Copy link
Owner

yoshidan commented Dec 1, 2023 •
edited
Loading

Now I merged PR.

@samster25 samster25 mentioned this issue Dec 1, 2023
Merged
@samster25
Copy link
Author

Great! When do you expect the new crate release to come out?

samster25 added a commit to Eventual-Inc/Daft that referenced this issue Dec 1, 2023
@samster25
[CHORE] drop s3 compat mode for gcs for anonymous mode (#1682)
f0ddb8c 
* `google-cloud-storage` crate now supports anonymous mode from this
[issue](yoshidan/google-cloud-rust#213) thanks
to this [PR](yoshidan/google-cloud-rust#217)
* This lets us drop S3 Compatibility mode for GCS
@yoshidan
Copy link
Owner

yoshidan commented Dec 5, 2023

Now I published the new crate (version = 0.15.0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yoshidan @samster25