-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestions before our first release #2
Comments
Another points are:
|
And we should follow this spec https://html.spec.whatwg.org/multipage/timers-and-user-prompts.html instead of Node.js Timers, thus BTW, browser doesn't own the
These functions should be delivered from ecosystem or user-land. |
Sorry about that @lolBig, |
Here is what i think we have to do before first release, some are consistent with you @yorkie :
Other points like code style is not the highest priority, we can adjust it later. Since |
I'm -1 on this, coding style is the higher priority for upcoming contributor, we should prepare them before this release.
The |
Done 🚚 |
How about removing the app.js and process.js? |
i will remove app.js after added user js code entry. |
Can we provide those at the other place like another npm package? |
rtnode-
and rename thertev
touv
, just curious why not using the nameuv
.rtnode-module
.At the codebase, renaming the below macros and functions are recommended:
RTNODE_FUNCTION
should beDEFINE_FUNCTION
.rtnode
tojs
, likejs_object_to_string
,js_object_set_method
andjs_object_set_property
.The text was updated successfully, but these errors were encountered: