Open latest workfile hook #11
Open
+35
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigRoy
reviewed
Nov 4, 2024
BigRoy
reviewed
Nov 4, 2024
| # Execute after workfile template copy | ||
| order = 10 | ||
| app_groups = ("equalizer", "sdv_3dequalizer") | ||
| launch_types = LaunchTypes.local |
There was a problem hiding this comment.
This must be a set
Suggested change
| launch_types = LaunchTypes.local | |
| launch_types = {LaunchTypes.local} |
There was a problem hiding this comment.
I copied it from
so this needs to be changed too?There was a problem hiding this comment.
I'd say so. @antirotor any idea where that sdv_3dequalizer comes from?
There was a problem hiding this comment.
I think it comes from the time where you couldn't have number at the start of the name, so it was prefixed by "sdv" -Science D-Visions". Then it stayed there for compatibility reasons
johhnry
force-pushed
the
open-latest-workfile
branch
from
cea46ff to
9aca4a0
Compare
BigRoy
added
type: enhancement
|
Hi, could we merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
This PR fixes #8
Additional review information
I can't test this right now because we don't have a license but maybe @antirotor can?
Testing notes: