From 8d80e09a1212d55208b4c77d7fbf8a45a7d327ad Mon Sep 17 00:00:00 2001
From: Yash Bagarka <yash@zededa.com>
Date: Wed, 18 Oct 2023 09:52:20 +0000
Subject: [PATCH] modified the conditonal trigger, removed an extra docker
 login command and added a tag build for future

---
 .github/workflows/publish.yml | 19 ++++++++-----------
 1 file changed, 8 insertions(+), 11 deletions(-)

diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
index d5725e6e15731..dd3555af9a4ca 100644
--- a/.github/workflows/publish.yml
+++ b/.github/workflows/publish.yml
@@ -1,19 +1,21 @@
 name: eve-kernel build
+
 on:
+  workflow_dispatch:
   pull_request_review:
-    types: [submitted]
-  pull_request:
-    types: [opened, synchronize, closed]
+    types: [ submitted ]
   push:
     branches:
       - "eve-kernel-amd64-v6.1.38-generic"
-  workflow_dispatch:
+
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
   cancel-in-progress: true
+
 jobs:
   packages:
     runs-on: self-hosted
+    if: ${{ github.event.review.state == 'approved' || github.ref == 'refs/heads/eve-kernel-amd64-v6.1.38-generic' || startsWith(github.ref, 'refs/tags') }}
     steps:
       - name: Get eve-kernel
         uses: actions/checkout@v3
@@ -23,17 +25,12 @@ jobs:
         run: |
           make -f Makefile.eve BRANCH?=${GITHUB_REF##*/} kernel-gcc
       - name: Log in to Docker Hub
-        if: ( github.event_name == 'pull_request' && github.event.pull_request.merged == true ) || github.event_name == 'push'  # Only if PR is merged or it was direct push
         uses: docker/login-action@v3
         with:
           username: ${{ secrets.RELEASE_DOCKERHUB_ACCOUNT }}
           password: ${{ secrets.RELEASE_DOCKERHUB_TOKEN }}
-      - name: Login to DockerHUB
-        if: ( github.event_name == 'pull_request' && github.event.pull_request.merged == true ) || github.event_name == 'push'  # Only if PR is merged or it was direct push
-        run: |
-          echo "${{ secrets.RELEASE_DOCKERHUB_TOKEN }}" |\
-             docker login -u "${{ secrets.RELEASE_DOCKERHUB_ACCOUNT }}" --password-stdin
       - name: Push eve-kernel-amd64-v6.1.38-generic if PR approved or pushed
-        if: ( github.event_name == 'pull_request' && github.event.pull_request.merged == true ) || github.event_name == 'push'  # Only if PR is merged or it was direct push
         run: |
           make -f Makefile.eve BRANCH?=${GITHUB_REF##*/} push-gcc
+          
+