Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem adding labels to choropleth map #57

Closed
geraldo opened this issue Oct 23, 2019 · 6 comments
Closed

Problem adding labels to choropleth map #57

geraldo opened this issue Oct 23, 2019 · 6 comments
Assignees

Comments

@geraldo
Copy link
Contributor

geraldo commented Oct 23, 2019

As you stated in issue #17 you won't add support for labels in the core library. I now try to add them with standard d3.js methods, but can't make them appear on the right position. Could you please have a look at this post?

@geraldo geraldo changed the title Best way to add labels to choropleth map Problem adding labels to choropleth map Oct 23, 2019
@yaph yaph self-assigned this Oct 23, 2019
@yaph
Copy link
Owner

yaph commented Oct 23, 2019

I replied on Stack Overflow. Also here is the bl.ocks page https://bl.ocks.org/yaph/5714d48fee1f1996415f73549e1b15c6

@yaph yaph closed this as completed Oct 23, 2019
@geraldo
Copy link
Contributor Author

geraldo commented Oct 24, 2019

Thanks for your help. Would you be interested in a pull request with an example based on this bl.ocks to show postUpdate in action?

@yaph
Copy link
Owner

yaph commented Oct 24, 2019

I am very interested in better documenting d3-geomap. An example for postUpdate is very appreciated. At some point I want to consolidate the content of the examples directory and the example maps on the documentation site. I created this issue hoping to get feedback from people using of this library.

@yaph
Copy link
Owner

yaph commented Nov 5, 2019

@geraldo if you are still interested in providing your example, I'd appreciate a PR with an accompanying test. I want to use the example maps in examples as test cases and have added 2 tests so far. I created a corresponding issue with some guidance #60

@geraldo
Copy link
Contributor Author

geraldo commented Nov 5, 2019

@yaph Yes, still interested, but with no time this week. I'll have it on my schedule for next week so.

@yaph
Copy link
Owner

yaph commented Nov 5, 2019

No need to hurry, just wanted to let you know about the changes I made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants