Fix elide-model-config build warnings #1971
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishi-aga
force-pushed
the
fixModelConfigBuildWarnings
branch
from
b72df48
to
6c64ecb
Compare
wcekan
reviewed
Mar 30, 2021
| private Set<String> tags = new LinkedHashSet<>(); | ||
|
|
||
| @JsonProperty("arguments") | ||
| @Singular | ||
| @Builder.Default |
There was a problem hiding this comment.
Why are we replacing Singular?
rishi-aga
force-pushed
the
fixModelConfigBuildWarnings
branch
from
60cf86f
to
323d96a
Compare
aklish
previously approved these changes
Mar 31, 2021
wcekan
reviewed
Mar 31, 2021
| @@ -68,10 +66,10 @@ | |||
| private String dbConnectionName; | |||
|
|
|||
| @JsonProperty("isFact") | |||
| private Boolean isFact = true; | |||
| private Boolean isFact; | |||
There was a problem hiding this comment.
@aklish are this fields purposely modifiable after building? Or should they all be final?
Suggested change
| private Boolean isFact; | |
| private final Boolean isFact; |
There was a problem hiding this comment.
I think we cannot declare all fields final, because we have inheritance logic
wcekan
reviewed
Mar 31, 2021
| @@ -51,7 +50,6 @@ | |||
| @Data | |||
There was a problem hiding this comment.
Use builder for Jackson deserializer
Suggested change
| @Data | |
| @JsonDeserialize(builder = Table.TableBuilder.class) | |
| @Data |
wcekan
requested changes
Mar 31, 2021
wcekan
reviewed
Mar 31, 2021
Comment on lines
+57
to
+60
| public Argument() { | ||
| this.values = new LinkedHashSet<>(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Remove and replace with JsonDeserialize builder.
Suggested change
| public Argument() { | |
| this.values = new LinkedHashSet<>(); | |
| } |
wcekan
reviewed
Mar 31, 2021
| @@ -33,7 +32,6 @@ | |||
| @Data | |||
There was a problem hiding this comment.
Suggested change
| @Data | |
| @JsonDeserialize(builder = Argument.ArgumentBuilder.class) | |
| @Data |
wcekan
reviewed
Mar 31, 2021
| @@ -48,14 +46,18 @@ | |||
|
|
|||
| @JsonProperty("values") | |||
| @JsonDeserialize(as = LinkedHashSet.class) | |||
| private Set<String> values = new LinkedHashSet<>(); | |||
| private Set<String> values; | |||
There was a problem hiding this comment.
Suggested change
| private Set<String> values; | |
| private final Set<String> values; |
wcekan
reviewed
Mar 31, 2021
Comment on lines
+96
to
+104
| public Dimension() { | ||
| this.hidden = false; | ||
| this.readAccess = "Prefab.Role.All"; | ||
| this.grains = new ArrayList<>(); | ||
| this.tags = new LinkedHashSet<>(); | ||
| this.values = new LinkedHashSet<>(); | ||
| this.arguments = new ArrayList<>(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Suggested change
| public Dimension() { | |
| this.hidden = false; | |
| this.readAccess = "Prefab.Role.All"; | |
| this.grains = new ArrayList<>(); | |
| this.tags = new LinkedHashSet<>(); | |
| this.values = new LinkedHashSet<>(); | |
| this.arguments = new ArrayList<>(); | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1892
Description
Fix Build warnings for elide-model-config
How Has This Been Tested?
Existing tests pass.
License
I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.