Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve exception handling #17

Open
simone3991 opened this issue Jul 26, 2021 · 2 comments
Open

Improve exception handling #17

simone3991 opened this issue Jul 26, 2021 · 2 comments
Assignees
@khaelys

Comments

@simone3991
Copy link
Member

simone3991 commented Jul 26, 2021 •
edited
Loading

As of now exceptions are thrown with messages that are pulled up to user level
@simone3991 simone3991 mentioned this issue Sep 3, 2021
Closed
@khaelys
Copy link
Collaborator

khaelys commented Sep 13, 2021 •
edited
Loading

Most of them were removed already. An important thing to improve is to create a custom exception tree so that we can discriminate between unexpected exceptions that are unrecoverable from the ones resolvable with a user retry.

@khaelys
Copy link
Collaborator

khaelys commented Oct 20, 2021

For example, when we change models and a user has a conversation state with the old model, the entire bot will break. We should check in the error handler if it is such a case and cleanup the conversation state.

@khaelys khaelys mentioned this issue Oct 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@khaelys khaelys

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simone3991 @khaelys