Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit test coverage #17

Open
bruceravel opened this issue Sep 16, 2014 · 0 comments
Open

unit test coverage #17

bruceravel opened this issue Sep 16, 2014 · 0 comments

Comments

@bruceravel
Copy link
Contributor

The unit testing framework is certainly helpful, but it does not cover everything in the code. Perhaps the stuff it covers is not super important for the EXAFS mission of this project....

Some examples:

  • There are no tests of the OVERLAP card ("card"! I cannot believe we are still using that word in 2014!). Problematic, I suppose, but I don't think that I have used Feff's overlap thingie in the last 20 years.
  • There are no tests that include any of the sigma^2 or cumulant stuff. Of course, I think that including such things at the level of Feff makes data analysis more confusing, so I could be comfortable with simply disabling those bits of the code.
  • There are no tests that cover things like ION, FOLP, or AFOLP.
  • There are no tests that cover non-Hedin-Lvndquist potentials.
  • There are not tests to exhaustively cover all the edges.
  • A bunch of other crazy stuff -- grids, JUMPRM, INTERSTITIAL, and so on -- is not covered.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant